tasklwIP - A Lightweight TCP/IP stack - Tasks: task #9218, TCP timestamp option support

 
 

You are not allowed to post comments on this tracker with your current authentication level.

task #9218: TCP timestamp option support

Submitted by:  Kieran Mansley <kieranm>
Submitted on:  Thu 26 Mar 2009 02:52:52 PM UTC  
 
Category:  None Should Start On:  Thu 26 Mar 2009 12:00:00 AM UTC
Should be Finished on:  Thu 26 Mar 2009 12:00:00 AM UTC Priority:  5 - Normal
Status:  Done Privacy:  Public
Percent Complete:  100% Assigned to:  Kieran Mansley <kieranm>
Open/Closed:  Closed Planned Release:  1.3.1
Effort:  0.00

Tue 28 Apr 2009 12:23:28 PM UTC, comment #4: 

Yeah, sorry for that, I forgot to post here after deciding to fix buf# 25608 - it's OK now since I moved sys_now() out of the #if NO_SYS part in sys.h. Not totally clean, but good enough for me.

Simon Goldschmidt <goldsimon>
Project Administrator
Tue 28 Apr 2009 07:56:57 AM UTC, comment #3: 

And as you've fixed bug #25608 does that mean that the issue with the timestamp option not building when NO_SYS=1 is now fixed?  I'm not sure if I need to do anything further.

Kieran Mansley <kieranm>
Project MemberIn charge of this item.
Mon 27 Apr 2009 08:00:22 PM UTC, comment #2: 

I just discovered that the timestamp option doesn't build with NO_SYS=1, since sys_now() is not defined in sys.h in that case. This seems to be part of bug #25608 though so I don't reopen this one.

Simon Goldschmidt <goldsimon>
Project Administrator
Tue 31 Mar 2009 02:13:42 PM UTC, comment #1: 

As there are no comments, I'm checking this in.  Please raise bugs if it causes problems.

Kieran Mansley <kieranm>
Project MemberIn charge of this item.
Thu 26 Mar 2009 02:52:52 PM UTC, original submission:  

I've implemented TCP timestamp option support, which required a rework of the arguments to tcp_enqueue() as discussed on lwip-devel a few months ago.

The code now seems to work to me, but I'd welcome other opinions before checking in.  Note that it defaults to off, so to test you must define LWIP_TCP_TIMESTAMPS = 1

Patch attached.

Kieran Mansley <kieranm>
Project MemberIn charge of this item.

 

Attached Files
file #17807:  tcp_timestamps added by kieranm (20KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by kieranm (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-05-01 kieranm StatusReady For Test => Done
        Percent Complete90% => 100%
        Open/ClosedOpen => Closed
    2009-03-26 kieranm Attached File- => Added tcp_timestamps, #17807

    Back to the top


    Powered by Savane 3.5