bugAVR Downloader/UploaDEr - Bugs: bug #55734, USBtiny programming of ATmega328p...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #55734: USBtiny programming of ATmega328p broken by Patch #9278

Submitter:  Austin Roach <ahroach>
Submitted:  Mon 18 Feb 2019 01:52:35 AM UTC
 
Category:  None Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  Fixed Privacy:  Public
Assigned to:  joerg_wunsch Originator Name:  * Austin Roach
Open/Closed:  Closed Release:  * SVN snapshot
Programmer hardware:  usbtiny Device type:  ATmega328p
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

Sun 07 Nov 2021 03:45:04 PM UTC, comment #3: 

Reverted patch #9728, and re-opened that patch tracker.

So back to previous version in r1459

Joerg Wunsch <joerg_wunsch>
Project Administrator
Mon 03 Aug 2020 09:15:09 PM UTC, comment #2: 

Same here. The patch breaks USBtiny for ISP targets.

Marius Greuel <mariusgreuel>
Project Member
Fri 13 Mar 2020 09:31:46 AM UTC, comment #1: 

Can confirm.

I tried to build the avrdude code myself to fix the 64K flash limitation on the tinyUSB-ISP (AVR pocket) programmer and found that this usbtiny_program_enable() logic is indeed flawed. A good working programmer returns 1 on success and not a zero like expected by this patch.

I undid the patch #9728 to get avrdude to work with this programmer.

Pieter-Jan Tuytschaever <aapje06>
Mon 18 Feb 2019 01:52:35 AM UTC, original submission:  

Programming an ATmega328p with a usbtiny-compatible programmer (Pocket AVR) was broken for me by Patch #9278.[1]

The logic in Patch #9278 is flawed. usbtiny_program_enable() (which is ultimately returning the value from usbtiny_cmd()) returns 1 on success. With the patch applied, if usbtiny_program_enable() always succeeds, the function will eventually fail and return -1. This is undoubtedly not the right behavior.

There may be some devices for which usbtiny_cmd() appears to fail, even though they are operating successfully. But breaking the operation of devices that are actually behaving correctly can't be the right fix.

[1] https://savannah.nongnu.org/patch/?9728

Austin Roach <ahroach>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by joerg_wunsch (Posted a comment)
  • -email is unavailable- added by mariusgreuel (Posted a comment)
  • -email is unavailable- added by aapje06 (Posted a comment)
  • -email is unavailable- added by ahroach (Submitted the item)
  • -email is unavailable- added by ahroach
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-11-07 joerg_wunsch StatusNone Fixed
        Assigned toNone joerg_wunsch
        Open/ClosedOpen Closed
    2019-02-18 ahroach Carbon-Copy- Added -email is unavailable-

    Back to the top


    Powered by Savane 3.9