patchAVR Downloader/UploaDEr - Patches: patch #9728, Fix UsbTiny programmer

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9728: Fix UsbTiny programmer

Submitter:  Martino Facchin <facchinm>
Submitted:  Thu 22 Nov 2018 08:27:13 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Postponed Privacy:  Public
Assigned to:  joerg_wunsch Open/Closed:  Open

Sun 07 Nov 2021 03:42:43 PM UTC, comment #2: 

Undid the patch due to bug #55734

Please re-submit, considering the complaints filed in that bug.

 Joerg Wunsch <joerg_wunsch>
Group administrator
Sat 05 Jan 2019 11:16:44 PM UTC, comment #1: 

Applied in r1429, thanks!

 Joerg Wunsch <joerg_wunsch>
Group administrator
Thu 22 Nov 2018 08:27:13 AM UTC, original submission:  

As reported on https://github.com/arduino/Arduino/issues/8198 ,
`patch #8924: Enable TPI for usbtiny` broke the functionality of such programmer for non TPI targets.

The refactor included reworking `usbtiny_initialize`, which used to call `pgm->program_enable` once and, in case of failure, reset the programmer and call it again.

The new code considers the return code successful if >=0, so the first failure is not reported and the programmer is not being reset.

The attached patch restores the previous behaviour by checking if `pgm->program_enable() == 0`

 Martino Facchin <facchinm>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #45511:  0001-usbtiny.patch added by facchinm (415B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by joerg_wunsch (Posted a comment)
  • -email is unavailable- added by facchinm (Submitted the item)

    •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-11-07 joerg_wunsch StatusDone Postponed
        Open/ClosedClosed Open
    2019-01-05 joerg_wunsch StatusNone Done
        Assigned toNone joerg_wunsch
        Open/ClosedOpen Closed
    2018-11-22 facchinm Attached File- Added 0001-usbtiny.patch, #45511

    Back to the top

    Copyright © 2024 Free Software Foundation, Inc.
    Verbatim copying and distribution of this entire article is permitted in any medium, provided this notice is preserved.
    The Levitating, Meditating, Flute-playing Gnu logo is a GNU GPL'ed image provided by the Nevrax Design Team.
    Page source code

    Powered by Savane 3.13-df36.
    Corresponding source code