patchAVR Downloader/UploaDEr - Patches: patch #9728, Fix UsbTiny programmer

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9728: Fix UsbTiny programmer

Submitted by:  Martino Facchin <facchinm>
Submitted on:  Thu 22 Nov 2018 08:27:13 AM UTC  
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  Joerg Wunsch <joerg_wunsch> Open/Closed:  Closed

Sat 05 Jan 2019 11:16:44 PM UTC, comment #1: 

Applied in r1429, thanks!

Joerg Wunsch <joerg_wunsch>
Project AdministratorIn charge of this item.
Thu 22 Nov 2018 08:27:13 AM UTC, original submission:  

As reported on https://github.com/arduino/Arduino/issues/8198 ,
`patch #8924: Enable TPI for usbtiny` broke the functionality of such programmer for non TPI targets.

The refactor included reworking `usbtiny_initialize`, which used to call `pgm->program_enable` once and, in case of failure, reset the programmer and call it again.

The new code considers the return code successful if >=0, so the first failure is not reported and the programmer is not being reset.

The attached patch restores the previous behaviour by checking if `pgm->program_enable() == 0`

Martino Facchin <facchinm>

 

Attached Files
file #45511:  0001-usbtiny.patch added by facchinm (415B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by joerg_wunsch (Posted a comment)
  • -email is unavailable- added by facchinm (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-01-05 joerg_wunsch StatusNone => Done
        Assigned toNone => joerg_wunsch
        Open/ClosedOpen => Closed
    2018-11-22 facchinm Attached File- => Added 0001-usbtiny.patch, #45511

    Back to the top


    Powered by Savane 3.5