bugLordsAWar! - Bugs: bug #24337, networked players have duplicate...


bug #24337: networked players have duplicate history records

Submitted by:  Ben Asselstine <benasselstine>
Submitted on:  Sun 21 Sep 2008 07:20:32 PM UTC  
Category:  None Severity:  3 - Normal
Item Group:  None Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open

Add a New Comment (Rich Markup)

You are not logged in

Please log in, so followups can be emailed to you.


Mon 07 Mar 2011 03:39:52 PM UTC, comment #2: 

addHistory is now only called from within top-level action methods in the player class.

However there still could be duplicate actions/history events going over the wire, that are also being generated locally.

There needs to be an audit done of actions and histories in a network game.  Histories are easier because we just need to check an autosave file on the client and server to see if duplicates are there.  Detecting duplicate actions is more difficult.

I am considering adding a unique id to each action and history event.

Ben Asselstine <benasselstine>
Project Administrator
Sat 05 Mar 2011 05:45:56 PM UTC, comment #1: 

It would be best if addHistory() was only ever called from within top level action methods in the player class.

This means that history events can be generated below those top level action methods, and passed back up.

Then it would be analogous to the situation with actions.

Ben Asselstine <benasselstine>
Project Administrator
Sun 21 Sep 2008 07:20:32 PM UTC, original submission:  

network players often have duplicated history events in the history report

it needs to be decided if the history events are going to be sent over the wire, or the network player will reproduce them as a result of getting actions.

Ben Asselstine <benasselstine>
Project Administrator


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:

No files currently attached


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by benasselstine (Submitted the item)

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.




    No changes have been made to this item

    Back to the top

    Powered by Savane 3.6