lwIP - A Lightweight TCP/IP stack - Bugs: bug #55199, ppp: inefficient debug disable
You are not allowed to post comments on this tracker with your current authentication level.
bug #55199: ppp: inefficient debug disable
Submitter: | Sergey A. Borshch <dushevny> | ||
Submitted: | Mon 10 Dec 2018 11:22:59 PM UTC | ||
Category: | PPP | Severity: | 1 - Wish |
Item Group: | Change Request | Status: | Fixed |
Privacy: | Public | Assigned to: | goldsimon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | git head |
Fri 10 Jan 2020 10:19:25 PM UTC, comment #2: |
Simon Goldschmidt <goldsimon> |
Fri 10 Jan 2020 08:46:18 PM UTC, comment #1: Sylvain, would you be ok with changing the ppp_*() functions to ppp_*(()) macros? That way, the macros would ensure debug code is not linked when disabled.
|
Simon Goldschmidt <goldsimon> |
Mon 10 Dec 2018 11:22:59 PM UTC, original submission:
Even in PPP debug output disabled by not defining PPP_DEBUG macro, ppp_dbglog(), ppp_info(), ppp_notice() etc. functions calls ppp_logit() function, which allocates 1024 bytes on stack, wastes CPU time in ppp_vslprintf() and calls ppp_log_write(), where debug output is actually disabled by PPPDEBUG() defined to empty code. Additionally all ppp debug strings are also linked into resulting executable. Replacing debug functions declaration in ppp_impl.h with
|
Sergey A. Borshch <dushevny> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 7 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2020-01-10 | goldsimon | Status | Confirmed | Fixed | |
Assigned to | gradator | goldsimon | |||
Open/Closed | Open | Closed | |||
2020-01-10 | goldsimon | Attached File | - | Added 0001-ppp-don-t-link-debug-functions-if-disabled.patch, #48199 | |
2018-12-18 | gradator | Severity | 3 - Normal | 1 - Wish | |
Status | None | Confirmed | |||
Assigned to | None | gradator |
Powered by Savane 3.13-f8d8.
Corresponding source code
Applied that patch, see task #14798