mainSpamAssassin Milter Plugin - Support: sr #100698, sanity checking needed for kill()

 
 

sr #100698: sanity checking needed for kill()

Submitter:  None
Submitted:  Fri 05 Apr 2002 03:21:39 AM UTC
   
 
Category:  None Priority:  5 - Normal
Severity:  2 - Minor Status:  None
Privacy:  Public Assigned to:  None
Originator Email:  -email is unavailable- Open/Closed:  Open
Operating System:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 06 Apr 2002 01:23:34 AM UTC, comment #1: 


Hi, can you post your changes ?

Anonymous
Fri 05 Apr 2002 03:21:39 AM UTC, original submission:  


I think one of the calls to kill() in spamass-milter
somehow got a value of 0 for the first argument,
killing off almost all the processes on the system
since I had it running as root.  I put "if(pid > 1)" in
front of all the calls to kill() and waitpid().

This may not affect the stock spamass-milter code,
since I've hacked mine quite a bit before this
happened.  But it probably can't hurt to do a little
sanity checking anyway.

(My other changes include renaming the SpamAssassin
constructor to SpamAssassin::start_spamc(), which I
call in mlfi_eoh().  I store the headers in a new
variable, and write them all out at once after calling
start_spamc() - this is so I can find a particular
hearder in the mail that indicates the local user the
mail is being sent to, so I can do "spamc -u username".
 If anyone's interested in my changes, or my other
milter that inserts the destination user in the
headers, let me know)

Sean Gabriel
System Administrator
Modwest, Inc.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.

 

No changes have been made to this item

Back to the top

Powered by Savane 3.13-4b48.
Corresponding source code