bugLordsAWar! - Bugs: bug #59898, Battle calculator crash everytime

 
 

bug #59898: Battle calculator crash everytime

Submitter:  - <_230772>
Submitted:  Sun 17 Jan 2021 06:10:12 PM UTC
   
 
Category:  scenario builder Severity:  3 - Normal
Item Group:  Git Head Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 11 Feb 2021 07:32:52 AM UTC, comment #2: 

Fixed.

The cause was related to the battle calculator passing in a tile located at -1,-1 for the stacks to fight on.  It was throwing away our virtual battle calculator tile and trying to grab the tile associated with the fighter... which is located at -1,-1.

I'm surprised a bounds-check didn't get triggered in valgrind, and that the crash didn't also happen on GNU/Linux.

Anyway, I'm happy to report the battle calculator no longer crashes on Windows.

Ben Asselstine <benasselstine>
Group administrator
Sun 17 Jan 2021 07:18:12 PM UTC, comment #1: 

Thank you for this bug!

I have reproduced it on Windows but it doesn't happen on Linux.  It's a strange one.

Ben Asselstine <benasselstine>
Group administrator
Sun 17 Jan 2021 06:10:12 PM UTC, original submission:  

https://savannah.nongnu.org/bugs/?59596
Sorry for too late, but I just now catched this bug again (I was hurry with translations and had no time to test game properly).
OS: Windows 10 build 1709 home edition.
Version: 0.3.2.
Steps:
1) Run LordsAWar!
2) Run LordsAWar! scenario bulider.
3) In LordsAWar! scenario builder run battle calculator.
4) Select sides: side a, for example, blue, side b is grey.
5) Add troops: side a - one dragon, side b - one elephant.
6) Press "Fight" button.
7) ???
8) Game will crash.
Repeatability: everytime.

This is a critical bug and need to fix as soon as possible.

- <_230772>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by benasselstine (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-02-11 benasselstine Open/ClosedOpen Closed
    2021-01-17 benasselstine CategoryNone scenario builder
        Item GroupNone Git Head

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code