lwIP - A Lightweight TCP/IP stack - Tasks: task #7143, Clean up opt.h
You are not allowed to post comments on this tracker with your current authentication level.
task #7143: Clean up opt.h
Submitter: | Jared Grubb <jgrubb> | ||
Submitted: | Thu 02 Aug 2007 09:48:22 PM UTC | ||
Category: | Documentation | Should Start On: | Thu 02 Aug 2007 07:00:00 AM UTC |
Should be Finished on: | Thu 02 Aug 2007 07:00:00 AM UTC | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | jgrubb | Percent Complete: | 100% |
Open/Closed: | Closed | Planned Release: | 1.3.0 |
Effort: | 0.00 |
Jump to the original submission
Wed 29 Aug 2007 09:01:01 AM UTC, comment #10: |
Kieran Mansley <kieranm> |
Fri 17 Aug 2007 06:33:35 PM UTC, comment #9: Committed to CVS. (I have synced the changes up with the changes made via Task #7136 (memp_std.h stuff) and the changes made by Marc over the last couple days; also I changed IGMP_STATS to depend on LWIP_IGMP).
|
Jared Grubb <jgrubb> |
Thu 16 Aug 2007 04:41:51 PM UTC, comment #8: Here is the proposed version.
|
Jared Grubb <jgrubb> |
Fri 03 Aug 2007 03:53:03 PM UTC, comment #7:
|
Jared Grubb <jgrubb> |
Fri 03 Aug 2007 03:52:49 PM UTC, comment #6:
|
Jonathan Larmour <jifl> |
Fri 03 Aug 2007 08:23:41 AM UTC, comment #5:
|
Frédéric Bernon <fbernon> |
Fri 03 Aug 2007 07:09:52 AM UTC, comment #4: I say go for it. It was likely set there in the original implementation/patch for convenience. It would make more sense in opt.h. |
Thomas Taranowski <taranowski> |
Fri 03 Aug 2007 01:25:26 AM UTC, comment #3: Question: Can I add LWIP_STATS_LARGE to the opt.h? Why is it separate?
|
Jared Grubb <jgrubb> |
Thu 02 Aug 2007 11:34:06 PM UTC, comment #2:
|
Jared Grubb <jgrubb> |
Thu 02 Aug 2007 11:05:29 PM UTC, comment #1: I don't see any PPP-related defines that wouldn't be relevant for tuning by the user. Which ones do you mean?
|
Jonathan Larmour <jifl> |
Thu 02 Aug 2007 09:48:22 PM UTC, original submission:
I have gone through opt.h and made all the commenting uniform (there were all sorts of styles used!). I had to just pick a style, but we can change it.
|
Jared Grubb <jgrubb> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 8 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2007-08-29 | jgrubb | Open/Closed | Open | Closed | |
2007-08-29 | jgrubb | Status | Ready For Test | Done | |
2007-08-17 | jgrubb | Status | None | Ready For Test | |
Percent Complete | 0% | 100% | |||
Assigned to | None | jgrubb | |||
Planned Release | None | 1.3.0 | |||
2007-08-16 | jgrubb | Attached File | - | Added opt.h, #13673 | |
2007-08-02 | jgrubb | Attached File | - | Added opt.h, #13560 |
Powered by Savane 3.13-02a9.
Corresponding source code
Yes please, then I think you can close this.